Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-216631 download streams logs #2770

Merged
merged 12 commits into from
Mar 22, 2024
Merged

CLOUDP-216631 download streams logs #2770

merged 12 commits into from
Mar 22, 2024

Conversation

jarjee
Copy link
Collaborator

@jarjee jarjee commented Mar 14, 2024 •
edited
Loading

Proposed changes

Adding streams audit logs to be downloaded under atlas streams instance download.

Ticket: CLOUDP-216631

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@jarjee jarjee self-assigned this Mar 14, 2024
@jarjee jarjee changed the title Cloudp 216631 download streams logs CLOUDP-216631 download streams logs Mar 14, 2024
@jarjee jarjee force-pushed the CLOUDP-216631_download-streams-logs branch from 4d9a025 to 5a7c8c3 Compare March 15, 2024 04:52
@jarjee jarjee marked this pull request as ready for review March 18, 2024 01:11
@jarjee jarjee requested a review from a team as a code owner March 18, 2024 01:11
@jarjee jarjee requested a review from a team March 18, 2024 01:11
@jarjee jarjee added documentation enhancement New feature or request go Pull requests that update Go code labels Mar 18, 2024
zach-carr
zach-carr previously approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@zach-carr zach-carr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor typo to fix - a space after a period

docs/command/atlas-streams-instances-download.txt Outdated Show resolved Hide resolved
gssbzn
gssbzn approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jarjee jarjee merged commit 6a8e6e0 into master Mar 22, 2024
17 checks passed
@jarjee jarjee deleted the CLOUDP-216631_download-streams-logs branch March 22, 2024 00:58
@fmenezes fmenezes mentioned this pull request Apr 5, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gssbzn gssbzn gssbzn approved these changes

@zach-carr zach-carr zach-carr left review comments

Assignees

@jarjee jarjee

Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jarjee @gssbzn @zach-carr